feat: centralize state management with React Context#3
Open
shivv23 wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces React Context to centralize shared state management, eliminating prop drilling across the Home route component tree.
Motivation
All shared state (
selectedFile,billType,showMenu) was owned byHome.tsxand passed as props toDashboard,NewFile, andMenu. Additionally, aLocalstore instance was created inside the component body on every render — a performance anti-pattern that allocates a new object each cycle.Changes
New context providers (
src/contexts/):StoreContext.tsx— provides a singletonLocalinstance viauseMemo, wrapped in auseStore()hook. Mounted at theApplevel so bothHomeandMeshKitPageshare the same instance.InvoiceContext.tsx— providesselectedFile,billType,showMenuand their setters via auseInvoice()hook. Mounted at theHomelevel where the state is owned.Refactored components:
Home.tsxInvoiceContext, renders children with zero propsDashboard.tsxstore,currentBillType,onOpenFileas propsuseStore()anduseInvoice(), receives onlyonOpenFileNewFile.tsxfile,store,billType,updateSelectedFileas propsuseStore()anduseInvoice(), zero propsMenu.tsxshowM,setM,file,updateSelectedFile,store,bTas propsuseStore()anduseInvoice(), zero propsMeshKitPage.tsxnew Local()on every renderuseStore()for singleton instanceApp.tsx — wraps the router in
<StoreProvider>to make the singleton store available app-wide.Dead code removal:
src/components/Files/(346 lines) — never imported by any component, legacy artifact superseded byDashboard.Type infrastructure:
src/types/meshkit-ionic.d.tstype declaration stub for@meshkit/ionic(local file dependency without published types).Architecture
Benefits
selectedFileandbillTypeeverywhere (no morefile/bT/currentBillTypevariants)useMemoensures oneLocalinstance across all rendersVerification
npx tsc --noEmitpasses with zero errors (excluding the pre-existing@meshkit/ionicmodule resolution addressed by PR #1).