refactor: eliminate dead and unused data files (~1 MB removed)#2
Open
shivv23 wants to merge 2 commits into
Open
refactor: eliminate dead and unused data files (~1 MB removed)#2shivv23 wants to merge 2 commits into
shivv23 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates dead and unused data files, removing 11,378 lines (~1,058 KB) from the source tree.
Changes
Deleted
src/app-data-new.ts(9,426 lines, 824 KB)app-data.tswith different branding; clearly an abandoned variantRemoved
DATA["ledger"]fromsrc/app-data.ts(1,952 lines, ~234 KB)ledgerkey contained a full set of SocialCalc spreadsheet templates (invoice layouts) that were loaded into memory at module import time but never accessed by any consumerHome.tsx,Files.tsx,Dashboard.tsx,NewFile.tsx,Menu.tsx) only readDATA["home"]— theledgerkey was dead weightImpact
src/app-data.ts: 3,908 lines reduced to 1,956 lines (50% reduction)src/app-data-new.ts: fully removed from the codebaseNote
npx tsc --noEmitshows a pre-existing error for@meshkit/ionicmodule resolution (the localfile:../Ionic-meshkit-releasedependency does not exist on this machine). This is unrelated to this PR and is addressed in PR #1 which adds a type declaration stub.