feat: add option to compare dtm with lidarhd stream#14
Open
nlenglet-ign wants to merge 4 commits into
Open
Conversation
leavauchier
reviewed
Jul 9, 2026
Comment on lines
+110
to
+114
| with open("data/stream_types.txt", "r") as f: | ||
| for l in f: | ||
| if stream_type in l: | ||
| stream_value = l.split(" ")[1] | ||
|
|
Member
There was a problem hiding this comment.
ça me parait moins robuste que d'avoir un dictionnaire directement dans un json, ce qui permettrait de faire
Suggested change
| with open("data/stream_types.txt", "r") as f: | |
| for l in f: | |
| if stream_type in l: | |
| stream_value = l.split(" ")[1] | |
| import json | |
| ... | |
| stream_types = json.load("data/stream_types.json") | |
| if stream_type in stream_types.keys() : | |
| stream_value = stream_types[stream_type] | |
| else : | |
| raise ... | |
Comment on lines
+123
to
+142
| # elif use_lidarHD: | ||
|
|
||
| # with tempfile.NamedTemporaryFile(suffix="_dtm_lidarHD.tif", delete=False) as tmp_lidarHD: | ||
| # success = _extract_tiles_from_stream( | ||
| # reference_dtm_file, pixel_per_meter=5, output_path=tmp_lidarHD.name, stream="IGNF_LIDAR-HD_MNT_ELEVATION.ELEVATIONGRIDCOVERAGE.LAMB93" | ||
| # ) | ||
|
|
||
| # if success: | ||
| # compute_difference_between_dtms(reference_dtm_file, tmp_lidarHD, output_difference_file) | ||
|
|
||
| # else: | ||
|
|
||
| # with tempfile.NamedTemporaryFile(suffix="_dtm_rgealti.tif", delete=False) as tmp_rge: | ||
|
|
||
| # success = _extract_tiles_from_stream( | ||
| # reference_dtm_file, pixel_per_meter=5, output_path=tmp_rge.name | ||
| # ) | ||
|
|
||
| # if success: | ||
| # compute_difference_between_dtms(reference_dtm_file, tmp_rge, output_difference_file) |
|
|
||
|
|
||
| def create_one_job_one_difference(store: Store, dir_in: Path, second_dir: Path | None, input_file: str, output: Path): | ||
| def create_one_job_one_difference(store: Store, dir_in: Path, second_dir: Path | None, input_file: str, output: Path, use_lidarHD: bool): |
Member
There was a problem hiding this comment.
use_lidarHD est toujorus valable ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.