Skip to content

[WIP] Feature merge results - #187

Draft
LeonardSchmiester wants to merge 27 commits into
developfrom
feature_mergeResults
Draft

[WIP] Feature merge results#187
LeonardSchmiester wants to merge 27 commits into
developfrom
feature_mergeResults

Conversation

@LeonardSchmiester

Copy link
Copy Markdown
Member

No description provided.

@dweindl dweindl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you could add typehints, and add an Arguments section to the docstrings

Comment thread misc/mergeResultFiles.py Outdated
fixed typo

Co-Authored-By: Daniel Weindl <dweindl@users.noreply.github.com>
@dweindl

dweindl commented Sep 7, 2019

Copy link
Copy Markdown
Member

ping

@dweindl

dweindl commented Oct 4, 2019

Copy link
Copy Markdown
Member

@LeonardSchmiester : ping

@dweindl dweindl changed the title Feature merge results [WIP] Feature merge results Dec 12, 2019
@dweindl

dweindl commented Mar 13, 2020

Copy link
Copy Markdown
Member

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- misc/mergeResultFiles.py  5
         

See the complete overview on Codacy

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl

dweindl commented Jun 16, 2020

Copy link
Copy Markdown
Member

@LeonardSchmiester : ping

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud

Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl
dweindl self-requested a review March 13, 2021 10:38
@sonarqubecloud

Copy link
Copy Markdown

@dweindl
dweindl removed their request for review March 25, 2021 09:04
dweindl and others added 7 commits June 28, 2021 09:20
* Fix race condition with parallel HDF5 calls

Add some locks, in particular for H5Location::nameExists.
Also remove some unnecessary H5File::getId calls.

* Safely close HDF5 files

* Check pthread_create retval

* cleanup
git subrepo clone --branch=develop --force git@github.com:AMICI-dev/AMICI.git deps/AMICI 

subrepo:
  subdir:   "deps/AMICI"
  merged:   "8ef53c88"
upstream:
  origin:   "git@github.com:AMICI-dev/AMICI.git"
  branch:   "develop"
  commit:   "8ef53c88"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
@sonarqubecloud

Copy link
Copy Markdown

@dweindl
dweindl force-pushed the develop branch 2 times, most recently from c25dd97 to 3b13b04 Compare July 13, 2021 14:22
@sonarqubecloud

sonarqubecloud Bot commented Oct 4, 2021

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl
dweindl marked this pull request as draft May 6, 2022 11:52
@dweindl
dweindl self-requested a review May 6, 2022 11:52
@dweindl
dweindl removed their request for review May 20, 2022 15:50
@dweindl
dweindl force-pushed the develop branch 2 times, most recently from bbf24f8 to e4fb08a Compare March 28, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants