Enhance RFS volume support: add bandwidth/iops update handling - #54
Merged
Conversation
sameshai
reviewed
Jun 25, 2025
sameshai
reviewed
Jun 25, 2025
sameshai
reviewed
Jun 25, 2025
Member
|
🔴 Coverage decreased from [87.7845%] to [87.5569%] |
2 similar comments
Member
|
🔴 Coverage decreased from [87.7845%] to [87.5569%] |
Member
|
🔴 Coverage decreased from [87.7845%] to [87.5569%] |
sameshai
reviewed
Jul 9, 2025
sameshai
requested changes
Jul 9, 2025
sameshai
left a comment
sameshai
left a comment
Member
There was a problem hiding this comment.
We need to setup review call and close on this @renukasingare
Member
|
🔴 Coverage decreased from [87.7845%] to [87.1293%] |
Member
|
🔴 Coverage decreased from [87.7845%] to [87.1328%] |
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
requested changes
Jul 14, 2025
sameshai
left a comment
sameshai
left a comment
Member
There was a problem hiding this comment.
Please change library and driver and test once.
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 14, 2025
sameshai
reviewed
Jul 15, 2025
sameshai
requested changes
Jul 15, 2025
sameshai
left a comment
sameshai
left a comment
Member
There was a problem hiding this comment.
Please put retry codes in utils.go and restore the retry logic
Member
|
🔴 Coverage decreased from [87.7845%] to [87.7103%] |
Member
|
🔴 Coverage decreased from [87.7845%] to [87.6879%] |
sameshai
reviewed
Jul 29, 2025
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
Signed-off-by: Renuka <renuka.singare@ibm.com>
renukasingare
force-pushed
the
regional-rfs-fixes
branch
from
August 8, 2025 14:29
1368a13 to
88e0ca2
Compare
sameshai
approved these changes
Aug 8, 2025
sameshai
left a comment
sameshai
left a comment
Member
There was a problem hiding this comment.
LGTM , lets do final review in master once I do maturity beta changes
Member
|
🔴 Coverage decreased from [87.7845%] to [87.7414%] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHE -> https://github.ibm.com/alchemy-containers/armada-storage/issues/7698
ibmcloud-volume-interface -> IBM/ibmcloud-volume-interface#53
Add regional share support i.e rfs profile support in the library (please add support for bandwidth and iops)
curl logs (before making changes) -> https://github.ibm.com/orgs/alchemy-containers/projects/99/views/27?pane=issue&itemId=1649277&issue=alchemy-containers%7Carmada-storage%7C7658
curl logs(After code fix ) :-> https://github.ibm.com/orgs/alchemy-containers/projects/99/views/27?pane=issue&itemId=1723995&issue=alchemy-containers%7Carmada-storage%7C7795
samples log :-> https://github.ibm.com/orgs/alchemy-containers/projects/99/views/27?pane=issue&itemId=1724009&issue=alchemy-containers%7Carmada-storage%7C7796