refactor(core): rename dict_to_measurements to observed_property_values_from_dict#1017
Draft
AlessandroPomponio wants to merge 2 commits into
Draft
refactor(core): rename dict_to_measurements to observed_property_values_from_dict#1017AlessandroPomponio wants to merge 2 commits into
AlessandroPomponio wants to merge 2 commits into
Conversation
…es_from_dicts Signed-off-by: Alessandro Pomponio <alessandro.pomponio1@ibm.com>
christian-pinto
previously approved these changes
Jun 9, 2026
christian-pinto
left a comment
christian-pinto
left a comment
Member
There was a problem hiding this comment.
The new function does not appear to be used anyway
Member
Author
|
Actually let's wait for #955 to go through before merging this one, as it's where the function is used - I'll mark it as draft and blocked by that issue |
Co-authored-by: Christian Pinto <55737893+christian-pinto@users.noreply.github.com> Signed-off-by: Alessandro Pomponio <10339005+AlessandroPomponio@users.noreply.github.com>
AlessandroPomponio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1006