Make azure blob client retry explicit - #169
Merged
Merged
Conversation
simon-20
requested changes
Aug 27, 2026
simon-20
left a comment
simon-20
left a comment
Contributor
There was a problem hiding this comment.
Hey @arobson-ods ,
A couple of small things:
- It needs a run through the linters (
tests/integration/test_dataset_update.pyhasn't hadisortrun on it). - Could you bump the version in pyproject (in Python projects, they are bumped by hand; in Node on Azure, they are done at the release stage)
- Could you add a
CHANGELOG.mdentry.
Preparatory step to centralise initialisation. Sets the the Azure SDK's default retry behaviour out explicity on the client.
arobson-ods
force-pushed
the
ar/make-client-retry-explicit
branch
from
August 27, 2026 13:32
5e87fef to
2302e7a
Compare
Contributor
Author
|
thanks @simon-20 - I've tidied it up. |
simon-20
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses issue #85 - Make Azure client retry behaviour explicit rather than rely on (hidden) defaults.
What Changed
Initialisation of Azure BlobServiceClient centralised in ServiceFactory. Variables controlling retry behaviour set explicitly. Values mirror those set by default in the Azure SDK.
Scope decisions
BlobServiceClient supports the context manager protocol so lifecycle could be managed cleanly rather than relying on explicit calls to
close(). Considered out of scope for this PR.