Skip to content

feat: logs non-secret env variables on startup - #164

Merged
arobson-ods merged 4 commits into
developfrom
ar/print-env-on-startup
Aug 25, 2026
Merged

arobson-ods merged 4 commits into
developfrom
ar/print-env-on-startup

Conversation

@arobson-ods

Copy link
Copy Markdown
Contributor

The configuration is now written to the log when the service is run. Each configuration variable in config.py carries a flag marking whether its value may be logged: so a variable added in future is private unless it is explicitly marked LOGGABLE.
The settings which come from the command line are logged too.

Current flags are my best guess.

@arobson-ods
arobson-ods requested a review from simon-20 August 6, 2026 17:21

@simon-20 simon-20 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrew, thanks for this, comments in line below

Comment thread tests/unit/test_config.py Outdated
Comment thread tests/unit/test_config.py Outdated
Comment thread tests/unit/test_config.py Outdated
Comment thread tests/unit/test_config.py Outdated
Comment thread tests/unit/test_config.py Outdated
Comment thread src/config/config.py Outdated
@arobson-ods arobson-ods self-assigned this Aug 25, 2026
@arobson-ods

Copy link
Copy Markdown
Contributor Author

Many thanks for this @simon-20

@arobson-ods
arobson-ods merged commit 61ed73e into develop Aug 25, 2026
1 check passed
@arobson-ods
arobson-ods deleted the ar/print-env-on-startup branch August 25, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants