Register GTIMES-Tsinghua V2.0 and GTIMES-Tsinghua V1.1 - #426
Conversation
Register Global TIMES model from Institute of Energy, Environment and Economy, Tsinghua University
There was a problem hiding this comment.
Pull request overview
Registers the GTIMES-Tsinghua V2.0 model by adding its native-to-common region mapping and defining the model’s native region country memberships.
Changes:
- Added a new
mappings/entry describing GTIMES-Tsinghua V2.0 native region codes and their aggregation into common region sets (World, R5, R10, R9). - Added a new
definitions/region/entry listing countries for each GTIMES-Tsinghua V2.0 native region.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| mappings/GTIMES-Tsinghua_V2.0.yaml | Introduces GTIMES-Tsinghua V2.0 native region codes and their aggregation into standard common regions. |
| definitions/region/GTIMES-Tsinghua_V2.0.yaml | Defines the GTIMES-Tsinghua V2.0 native regions in terms of country membership. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - EUR: GTIMES-Tsinghua V2.0|European | ||
| - world: GTIMES-Tsinghua V2.0|world |
There was a problem hiding this comment.
This Copilot review is right (remove this line) for the wrong reasons.
| - KOR: GTIMES-Tsinghua V2.0|Korea | ||
| - LAM: GTIMES-Tsinghua V2.0|Latin America | ||
| - MEA: GTIMES-Tsinghua V2.0|Middle East | ||
| - ODA: GTIMES-Tsinghua V2.0|Southeast Asia |
| - GTIMES-Tsinghua V2.0|Southeast Asia: | ||
| countries: |
Register Global TIMES model from Institute of Energy, Environment and Economy, Tsinghua University
ZhangShuTHU
changed the title
danielhuppmann
left a comment
danielhuppmann
left a comment
There was a problem hiding this comment.
I suggest to use a lower-case "v" like v1.1 and v2.0 for consistency with other registered models and package-version convention.
| - Switzerland | ||
| - United Kingdom | ||
| - Vatican | ||
| - GTIMES-Tsinghua V1.1|world |
There was a problem hiding this comment.
The "World" region will automatically be computed from the reported regions and should not be defined as an own region, please remove this line
| - GTIMES-Tsinghua V1.1|world |
| - ODA: GTIMES-Tsinghua V1.1|Southeast Asia | ||
| - USA: GTIMES-Tsinghua V1.1|United States | ||
| - WEU: GTIMES-Tsinghua V1.1|West Europe | ||
| - world: GTIMES-Tsinghua V1.1|world |
There was a problem hiding this comment.
Please remove this mapping. If you want, you can report global results directly as "World" region - these values will be used instead of the automated region-aggregation from the native regions.
| - world: GTIMES-Tsinghua V1.1|world |
| - Sweden | ||
| - United Kingdom | ||
| - Vatican | ||
| - GTIMES-Tsinghua V2.0|world |
There was a problem hiding this comment.
Please remove
| - GTIMES-Tsinghua V2.0|world |
| - EUR: GTIMES-Tsinghua V2.0|European | ||
| - world: GTIMES-Tsinghua V2.0|world |
There was a problem hiding this comment.
This Copilot review is right (remove this line) for the wrong reasons.
Standardizes GTIMES-Tsinghua identifiers in both v1.1 and v2.0 files by changing `V` to `v` across model names and native region paths. It also removes the explicit `|world` native region entries from region definitions and mappings, relying on `common_regions` for World aggregation to keep naming and hierarchy consistent.
Register Global TIMES model (GTIMES-Tsinghua V2.0) from Institute of Energy, Environment and Economy, Tsinghua University
@danielhuppmann @phackstock
Users:
Name: Shu ZHANG
Email: zhang-s@mail.tsinghua.edu.cn
IIASA manager username: zhangshu
Github: ZhangShuTHU
Name: Wenying CHEN
Email: chenwy@mail.tsinghua.edu.cn
IIASA manager username: chenwy