fix: remove duplicate empty AppIcon catalog that broke App Store builds - #23
Merged
Conversation
The app target compiled two asset catalogs: ZenLock/Assets.xcassets (the full, correct icon set including the 1024 ios-marketing icon) and a stray ZenLock/Resources/Assets.xcassets whose only content was an AppIcon set with an empty 1024x1024 slot (no image). With two catalogs both defining AppIcon, the empty marketing slot can win, so the archive ships without a valid App Store icon — which is why simulator/local/GitHub builds pass but Xcode Cloud's "Prepare Build for App Store Connect" step fails (it validates the 1024 icon). Removed the stray catalog (it held no real assets) and regenerated the Xcode project with XcodeGen so the committed .xcodeproj no longer references it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015Qvf9BnsiAuaiSPbsZazgr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Xcode Cloud's Archive → Prepare Build for App Store Connect step fails (Build 29), with no clear error — while local Xcode, on-device, and the GitHub simulator build all pass.
Root cause: the app target compiles two asset catalogs, both defining
AppIcon:ZenLock/Assets.xcassets— the full, correct icon set (incl. the required1024x1024 ios-marketingicon)ZenLock/Resources/Assets.xcassets— a stray catalog whose only content is an AppIcon set with an empty 1024 slot (no image file)With two catalogs defining
AppIcon, the empty marketing slot can win, so the archive ships without a valid App Store marketing icon. Simulator/local/CI builds don't validate that icon — but App Store "Prepare Build" does, hence the failure only there.Fix
ZenLock/Resources/Assets.xcassets(it contained no real assets).ZenLock.xcodeprojwith XcodeGen (project's source of truth; Xcode Cloud builds the committed project, so the reference had to be removed from it). Thepbxprojnow references a single asset catalog; the scheme diff is benign XcodeGen metadata.Verification
If this isn't the whole story
I can't read the Xcode Cloud logs (Apple-auth gated), so this is the strongest concrete defect found, not a confirmed log line. The authoritative error is in the build's Logs tab or the email App Store Connect sends. Other things worth checking there:
1) if a build was already accepted.🤖 Generated with Claude Code