Repository navigation
Fix cash shop lock after purchase failure - #269
Merged
Merged
Conversation
Replace packetCashShopUpdateAmounts with packetCashShopError in all failure paths that were missing the CSAction error response. The client expects a SendChannelCSAction packet to complete the operation flow; only sending SendChannelCSUpdateAmounts left the UI locked. Affected operations: - BuyItem: unknown SN, not on sale, invalid currency, item creation failure, and unknown currency at charge time - BuyPackage: unknown SN, no package items, invalid currency, zero itemID, item creation failure, and GiveItem failure - IncreaseSlots: unknown currency type Agent-Logs-Url: https://github.com/Hucaru/Valhalla/sessions/2157034a-85bb-4704-bbc9-c72f3b5006b3 Co-authored-by: ErwinsExpertise <44278151+ErwinsExpertise@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix cash shop lock after purchase failure
Fix cash shop lock after purchase failure
Mar 30, 2026
Hucaru
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed cash shop operations (buy item, buy package, increase slots) left the client UI locked. The client waits for a
SendChannelCSActionresponse to complete the operation flow, but several error paths only sentSendChannelCSUpdateAmounts, which updates the NX/MP display without signaling operation completion.Changes
packetCashShopUpdateAmountswithpacketCashShopErrorfor unknown SN, not-on-sale, invalid currency, and item creation failure paths. Add missing error response for unreachable currency branch at charge time.GiveItemfailure paths.return).Before:
After: