Performance improvements to cache - #1659
Merged
Merged
Conversation
Three hot-path changes: dedicated typename map on InMemoryStorage (O(1) lookup instead of full layer traversal), toNotify as Set<SubscriptionSpec> in writeSelection (dedup at add time, avoids FieldSelection tuple overhead), and memoized getFieldsForType via WeakMap (O(1) for repeated selection+type pairs). Benchmark CI now runs 3× on each branch sequentially on the same runner and takes the median, so comparisons are machine-stable. Benchmark selections hoisted to module scope so the getFieldsForType memo actually hits.
Longer per-benchmark time reduces RME at the source; adaptive thresholds in compare.js absorb the remaining noise, so the 3-run median is no longer needed.
|
…hold handles variance
AlecAivazis
added a commit
that referenced
this pull request
Jun 19, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an O(n²) hot path in writeSelection that became expensive on records with many fields. Typical operations are ~40% faster; wide records (100+ fields) see much larger gains (253x for some benchmarks).
Also adds a benchmark CI job that runs on every PR touching the cache, so regressions are caught automatically.