Repository navigation
feat(qa): Playwright-first browser QA, named targets, /orc:explain - #112
Merged
Merged
Conversation
… stitched QA video with chapters
… narration, ffmpeg timeline assembly
…non-clobbering .mcp.json merge
…port renders chapter seek list
…ind a hard-outward Post gate; ship offers it after PR open
…eferences; --target on qa/evidence/flow
…ht agents, plan gate, healer cap, stitched evidence
…cript rules, Explainer gate, render pipeline
…, playwright packet column; e2e proof excluded from LOC budget
…tyle/voice settings
…log, config, example 18
…/render/id guards, strict ORC_QA_USER
…xplain validates ids everywhere, kokoro pinned with lockfile + HF revision
…pload, generated-test scan + healer boundary check
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 37931819 | Triggered | Generic CLI Secret | 6180ddc | scripts/ci/verify-targets.sh | View secret |
| 37931818 | Triggered | Username Password | 1a335bb | scripts/ci/verify-targets.sh | View secret |
| 37931820 | Triggered | Generic CLI Secret | 32f18d4 | scripts/ci/verify-targets.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…t scanners skip them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Browser QA ran only against a local env and left an untagged recording behind; nothing explained what shipped. Plan with the 17 grilled decisions:
.orc/feat-qa-playwright-train/files/plan.md.What changed
orc-targets: named QA targets in.orc/targets.json; credentials asliteral | op:// | env:references resolved inline only;--targeton qa/flow/evidence;guardtargets skip@mutatingscenarios; ad-hoc--webURLs never carry local creds.init-agents) in a committede2e/; plan gate; healer cap 3; generated-test scan;orc-qa-videostitches one step-taggedqa-<branch>.webm+chapters.json; manifest v2 with chapter seek links in the report./orc:explain: golden-path demo pass + animate graphic segments (pinned commit, scenes authored in-session) + kokoro-js local narration →explainer-<branch>.mp4.Postgate; Artifact upload is media-only (traces carry session cookies).e2e/specs/**,e2e/tests/**, and lockfiles at any depth.How tested
17
scripts/ci/*.shgreen, 5 new fixtures (targets 17, playwright-env 22, qa-video 12, explain 12, pr-size 1). Security review: 8 findings, all fixed (32f18d4, 9906300). kokoro narration + ffmpeg assembly smoke-tested locally: 12 s 1080p mp4 with audio.Notes
brew install ffmpeg.graphicsrenders only withORC_ANIMATE_RENDER=1after the scenes exist; fallback cards otherwise.Size-budget-override: One-PR train per settled decision 17 — 12 slices share the qa-manifest schema and the browser-qa protocol; splitting would cross-edit the same files.