Skip to content

CORS policy: Response to preflight request doesn't pass access co... #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harshvardhan60792 wants to merge 1 commit into from
Closed

CORS policy: Response to preflight request doesn't pass access co... #3530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/self-hosting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Generates secrets, writes `.env` + `puter/config/config.json`, downloads `docker
| `puter-valkey` | `valkey/valkey:8-alpine` | Redis-compatible cache + rate-limiter |
| `puter-dynamo` | `amazon/dynamodb-local` | KV store — table auto-created on first boot |
| `puter-s3` | `rustfs/rustfs` | S3-compatible object storage (MinIO drop-in noted in file) |
| `puter-s3-init` | `amazon/aws-cli` | One-shot — creates the bucket on first boot, then exits |
| `puter-s3-init` | `amazon/aws-cli` | One-shot — creates the bucket and applies its CORS policy on first boot, then exits |

Optional services (compose profile `ai`, opt-in):

Expand Down
16 changes: 15 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,18 @@ services:

s3-init:
# One-shot container that creates the `puter-local` bucket on first
# boot. Exits 0 once the bucket exists; stays exited 0 thereafter.
# boot and makes sure it has a CORS policy. Exits 0 once both are in
# place; stays exited 0 thereafter.
#
# The CORS policy matters because browsers PUT/GET straight to
# `s3.<domain>` using presigned URLs (see the `@s3` block in
# caddy/Caddyfile) — without it, uploads through the GUI (e.g.
# Dev Center's "Use files") fail preflight with "No
# 'Access-Control-Allow-Origin' header is present". Puter's own
# subdomains are dynamic (per-user site./app. hosts, optional custom
# domains), so pinning AllowedOrigins to a fixed list isn't practical
# here; access to the bucket is already gated by the request's AWS
# signature, so a wildcard origin doesn't loosen that.
image: amazon/aws-cli:latest
container_name: puter-s3-init
depends_on:
Expand All @@ -163,6 +174,9 @@ services:
echo "creating bucket $$bucket"
aws --endpoint-url "$$endpoint" s3 mb "s3://$$bucket"
fi
echo "applying bucket CORS policy"
echo '{"CORSRules":[{"AllowedOrigins":["*"],"AllowedMethods":["GET","PUT","POST","HEAD"],"AllowedHeaders":["*"],"ExposeHeaders":["ETag","x-amz-request-id"],"MaxAgeSeconds":3600}]}' > /tmp/cors.json
aws --endpoint-url "$$endpoint" s3api put-bucket-cors --bucket "$$bucket" --cors-configuration file:///tmp/cors.json
restart: "no"

# ── Optional: local LLM ───────────────────────────────────────────
Expand Down