Graffux Play release: install armv7 Rust target - #91
Merged
Merged
Conversation
Graffux now builds libgraffux_wgpu.so for armeabi-v7a as well as arm64 (HereLiesAz/Graffux#513); with graffux.wgpu.require=true the release build fails unless both targets are installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjPquKJ7xqp1csGKuBwo3s
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe Graffux Play release profile now installs both AArch64 and ARMv7 Android Rust targets before building, enabling Sequence diagram for the Graffux ARMv7 release buildsequenceDiagram
participant GraffuxRelease as Graffux_Play_Release
participant Rustup
participant Gradle
participant NativeLibrary as libgraffux_wgpu.so
GraffuxRelease->>Rustup: rustup target add aarch64-linux-android armv7-linux-androideabi
Rustup-->>GraffuxRelease: Android Rust targets installed
GraffuxRelease->>Gradle: ./gradlew bundleRelease -Pgraffux.wgpu.require=true
Gradle->>NativeLibrary: Build AArch64 and armeabi-v7a variants
NativeLibrary-->>Gradle: Native libraries available for release
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🔵 In progress View logs |
workflows | 4ad1ded | Sep 29 2026, 02:18 AM |
HereLiesAz
marked this pull request as ready for review
September 29, 2026 02:18
There was a problem hiding this comment.
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Needs a human reviewer. If the added Rust target is unsupported or incompatible with the release build, the release job should fail and reverting restores the previous command. If it produces an incorrect armv7 artifact that is published, the affected release would need to be withdrawn or replaced rather than being fixed by the revert alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Graffux's
PURPOSE_PROFILESentry (scripts/semantic_catalog.py),pre_build_commandnow installs the armv7 target as well:rustup target add aarch64-linux-android armv7-linux-androideabi.HereLiesAz/Graffux#513 builds
libgraffux_wgpu.sofor armeabi-v7a too. The release runs with-Pgraffux.wgpu.require=true, so it would fail without this target. It's harmless if merged first: an installed target that nothing uses changes nothing.Only Graffux's profile is affected. All
scripts/test_*.pytests andaudit_workflow_collectionpass.🤖 Generated with Claude Code
https://claude.ai/code/session_01AjPquKJ7xqp1csGKuBwo3s
Generated by Claude Code
Summary by Sourcery
Bug Fixes: