Skip to content

Graffux Play release: install armv7 Rust target - #91

Merged
HereLiesAz merged 2 commits into
mainfrom
claude/graffux-armv7-target
Sep 29, 2026
Merged

HereLiesAz merged 2 commits into
mainfrom
claude/graffux-armv7-target

Conversation

@HereLiesAz

@HereLiesAz HereLiesAz commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

In Graffux's PURPOSE_PROFILES entry (scripts/semantic_catalog.py), pre_build_command now installs the armv7 target as well: rustup target add aarch64-linux-android armv7-linux-androideabi.

HereLiesAz/Graffux#513 builds libgraffux_wgpu.so for armeabi-v7a too. The release runs with -Pgraffux.wgpu.require=true, so it would fail without this target. It's harmless if merged first: an installed target that nothing uses changes nothing.

Only Graffux's profile is affected. All scripts/test_*.py tests and audit_workflow_collection pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AjPquKJ7xqp1csGKuBwo3s


Generated by Claude Code

Summary by Sourcery

Bug Fixes:

  • Enable Graffux release builds to include the Rust target required for armeabi-v7a native libraries.

Graffux now builds libgraffux_wgpu.so for armeabi-v7a as well as arm64
(HereLiesAz/Graffux#513); with graffux.wgpu.require=true the release build
fails unless both targets are installed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AjPquKJ7xqp1csGKuBwo3s
@sourcery-ai

sourcery-ai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The Graffux Play release profile now installs both AArch64 and ARMv7 Android Rust targets before building, enabling armeabi-v7a support for libgraffux_wgpu.so without affecting other profiles.

Sequence diagram for the Graffux ARMv7 release build

sequenceDiagram
    participant GraffuxRelease as Graffux_Play_Release
    participant Rustup
    participant Gradle
    participant NativeLibrary as libgraffux_wgpu.so

    GraffuxRelease->>Rustup: rustup target add aarch64-linux-android armv7-linux-androideabi
    Rustup-->>GraffuxRelease: Android Rust targets installed
    GraffuxRelease->>Gradle: ./gradlew bundleRelease -Pgraffux.wgpu.require=true
    Gradle->>NativeLibrary: Build AArch64 and armeabi-v7a variants
    NativeLibrary-->>Gradle: Native libraries available for release
Loading

File-Level Changes

Change Details Files
Extend Graffux Play release setup to install the Rust toolchain target required for ARMv7 Android native builds.
  • Add armv7-linux-androideabi alongside the existing AArch64 Android target in the profile’s pre-build command.
  • Keep the change scoped to Graffux’s release profile, whose build requires the WGPU native library.
scripts/semantic_catalog.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
🔵 In progress
View logs
workflows 4ad1ded Sep 29 2026, 02:18 AM

@HereLiesAz
HereLiesAz marked this pull request as ready for review September 29, 2026 02:18
@HereLiesAz
HereLiesAz merged commit fa128e0 into main Sep 29, 2026
2 of 3 checks passed
@HereLiesAz
HereLiesAz deleted the claude/graffux-armv7-target branch September 29, 2026 02:18

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Needs a human reviewer. If the added Rust target is unsupported or incompatible with the release build, the release job should fail and reverting restores the previous command. If it produces an incorrect armv7 artifact that is published, the affected release would need to be withdrawn or replaced rather than being fixed by the revert alone.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sourcery assessment

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants