Skip to content

Restore PR CI; build the Kotlin for CodeQL; OpenCode security review - #228

Merged
HereLiesAz merged 3 commits into
mainfrom
claude/amazing-fermi-3o92qn-ci
Sep 27, 2026
Merged

HereLiesAz merged 3 commits into
mainfrom
claude/amazing-fermi-3o92qn-ci

Conversation

@HereLiesAz

@HereLiesAz HereLiesAz commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

CI. .github/workflows/ci.yml is back. It is the source that central CI Validation binds to by hash, so the controller swaps it for a tracker. It runs:

  • workspace build + test on Node 24;
  • the conformance-fixture drift check;
  • the Compose storefront: Wasm, Android assembleDebug, desktopTest, :azp:test.

Needs HereLiesAz/workflows#83 (hash 37131af3…).

CodeQL. java-kotlin used autobuild, which finds no build at the repo root, so it failed on every run including main. It is now a manual build:

  • Java 17;
  • ./gradlew compileKotlinDesktop :azp:compileKotlin in apps/storefront-cmp, run under the tracer;
  • version frozen.

CodeQL 2.27.1 (the version the runner uses) supports Kotlin 2.4.20.

Security review. .github/workflows/security-review.yml binds to the new central opencode-security-review.yml. It is a read-only OpenCode review of each PR, posted as one comment and advisory only. It replaces the Copilot security review. Needs HereLiesAz/workflows#84 (hash f92c8098…).

After it lands, turn off the Copilot review in Settings → Code security / Copilot → Code review so the failing github-advanced-security check stops appearing.

Order: workflows#83 and #84 merge first, then this PR.

Validated locally:

  • pnpm fixtures shows no drift.
  • The CodeQL compile command succeeds.
  • desktopTest and :azp:test pass.
  • assembleDebug and Wasm were not run here: this sandbox has no Android SDK, and yarn gets a 403 from codeload. Both run on the hosted runner.

🤖 Generated with Claude Code

https://claude.ai/code/session_01QwYWVPse8spRrfMMcuTJPv

Summary by Sourcery

Restore repository validation, make Kotlin CodeQL analysis build successfully, and replace the pull-request security review with an advisory OpenCode workflow.

New Features:

  • Restore pull-request and push CI validation for workspace builds, tests, conformance fixtures, and Compose storefront checks.
  • Add an advisory OpenCode security review workflow for pull requests.

Bug Fixes:

  • Fix Kotlin CodeQL analysis by replacing repository-root autobuild detection with a manual storefront build.

Enhancements:

  • Configure CodeQL Kotlin analysis with the storefront Java 17 toolchain and relevant Kotlin compilation targets.

CI:

  • Run CI validation on Node 24 and the Compose storefront on the hosted runner.
  • Replace the previous Copilot security review workflow with the centrally managed OpenCode review.

Tests:

  • Add automated detection of stale conformance fixtures.

ci.yml is back as the source central CI Validation binds to (HereLiesAz/workflows
semantic_catalog.py): workspace build + test on Node 24, conformance fixture drift,
and the Compose storefront (Wasm, Android, desktopTest, :azp:test).

CodeQL java-kotlin was autobuild, which finds no build at the root and fails on
every run. It now builds storefront-cmp's desktop target and the azp verifier
with Gradle under the tracer (Java 17, version frozen).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QwYWVPse8spRrfMMcuTJPv
@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
azphalt Error Error Sep 27, 2026 6:17am UTC

@sourcery-ai

sourcery-ai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Reviewer's Guide

Restores hash-bound CI validation and expands it to cover workspace, fixture, and Compose storefront checks, while fixing CodeQL Kotlin analysis by using a Java 17 manual Gradle build from the storefront project instead of repository-root autobuild.

Sequence diagram for manual Kotlin CodeQL build

sequenceDiagram
    participant CodeQL as CodeQL workflow
    participant Runner as GitHub runner
    participant Gradle as storefront-cmp Gradle
    participant Kotlin as Kotlin compiler

    CodeQL->>Runner: setup-java Java 17
    CodeQL->>Gradle: compileKotlinDesktop
    CodeQL->>Gradle: :azp:compileKotlin
    Gradle->>Kotlin: compile Kotlin sources under tracer
    Kotlin-->>Gradle: compilation results
    Gradle-->>CodeQL: build succeeds
    CodeQL->>CodeQL: analyze
Loading

File-Level Changes

Change Details Files
Restores the repository CI workflow with Node and Compose storefront validation jobs.
  • Adds workspace install, build, and test validation on Node 24.
  • Adds a generated conformance-fixture drift check.
  • Adds Wasm, Android debug assembly, desktop tests, and Kotlin verifier tests for the Compose storefront.
  • Pins the storefront validation to Java 17 and prevents version mutation during CI.
.github/workflows/ci.yml
Replaces failing CodeQL Kotlin autobuild with a traced Gradle compilation tailored to the storefront project.
  • Switches the java-kotlin matrix entry from autobuild to manual mode.
  • Configures Corretto Java 17 for Kotlin analysis.
  • Compiles the desktop Kotlin source and the azp subproject from apps/storefront-cmp under CodeQL tracing.
  • Disables Gradle build cache and freezes the project version during analysis.
.github/workflows/codeql.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

security-review.yml is the source HereLiesAz/workflows' opencode-security-review.yml
binds to: a read-only OpenCode review of each pull request, posted as one comment.
Advisory. Replaces the Copilot security review, which fails on every run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QwYWVPse8spRrfMMcuTJPv
@HereLiesAz HereLiesAz changed the title Restore PR CI; build the Kotlin for CodeQL Restore PR CI; build the Kotlin for CodeQL; OpenCode security review Sep 27, 2026
@HereLiesAz
HereLiesAz marked this pull request as ready for review September 27, 2026 06:17
@HereLiesAz
HereLiesAz merged commit ab06338 into main Sep 27, 2026
10 of 11 checks passed
@HereLiesAz
HereLiesAz deleted the claude/amazing-fermi-3o92qn-ci branch September 27, 2026 06:17

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @HereLiesAz, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 1 day and 16 hours by commenting @sourcery-ai review. Upgrade to get a review now.

This branch had an error being deployed

1 failed deployment
Preview — 927a0c6f Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants