add Nix flake with single-source version#55
Open
mipmip wants to merge 1 commit into
Open
Conversation
Add a multi-system flake (x86_64/aarch64, Linux and macOS) that builds the rmux and rmux-daemon binaries, exposes a nix run app, and provides a dev shell. The package version is parsed from the [workspace.package] table in Cargo.toml at evaluation time rather than hardcoded, so the version stays single-sourced. Dependency hashes come from the committed Cargo.lock, so no cargoHash needs recomputing on dependency changes. Tests are not run during the build (doCheck = false): the integration suites need real PTYs/sockets and host tools and include timing-sensitive cases that are unreliable in the hermetic sandbox; the full suite runs in CI and locally. Add docs/nix-packaging.md with the maintainer release notes and a README install section.
Contributor
|
Thank you for your contribution, glad you like it ! The flake direction is good, and keeping flake.nix/flake.lock at the repository root is the right layout for Before merging, we need this wired into CI because README install paths must be release-gated. Please add a Nix CI job that runs:
Also, please replace the regex-based Cargo.toml version parsing with After that, I’m comfortable treating Nix as an official install path. Let me know if you want me to take care of it I think I'll add snap right after in the same release |
Author
|
Busy schedule, but I'm on it. Cool to contribute |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a wider exposure and adoption of this project I've added flake so Nix/NixOS user can run and develop rmux. I'm using the forked version myself for a fun interessing project.
Thanks for this great project!
Add a multi-system flake (x86_64/aarch64, Linux and macOS) that builds the rmux and rmux-daemon binaries, exposes a nix run app, and provides a dev shell.
The package version is parsed from the [workspace.package] table in Cargo.toml at evaluation time rather than hardcoded, so the version stays single-sourced. Dependency hashes come from the committed Cargo.lock, so no cargoHash needs recomputing on dependency changes.
Tests are not run during the build (doCheck = false): the integration suites need real PTYs/sockets and host tools and include timing-sensitive cases that are unreliable in the hermetic sandbox; the full suite runs in CI and locally.
Add docs/nix-packaging.md with the maintainer release notes and a README install section.