Repository navigation
Auto-join space rooms when accepting space invites - #56
Merged
Merged
Conversation
After joining a space from an invite (inbox Invites page or the app shell's community invite row), fetch the space hierarchy and join every room and sub-space the user hasn't joined yet, in the background so navigation isn't held up. Invite-only and knock rooms are skipped, failed joins are ignored, and rate limits are retried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SW3Ebb16smU9Xmr7hRTgg2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user accepts an invite to a space, automatically join all joinable rooms within that space in the background. This improves the user experience by populating the space with its child rooms without requiring manual joins.
Changes:
Added
joinSpaceRooms.tsutility module that:Updated
Invites.tsxto calljoinSpaceRooms()after accepting a space inviteUpdated
CommunityList.tsxto calljoinSpaceRooms()after joining a community spaceAdded comprehensive unit tests for
getSpaceRoomsToJoin()covering:Test Plan:
Added unit tests in
joinSpaceRooms.test.tscovering the room filtering and via server logic. Runnpm testto verify.Fixes #
https://claude.ai/code/session_01SW3Ebb16smU9Xmr7hRTgg2