Repository navigation
Improve image post rendering with aspect ratio and caption support - #55
Merged
Merged
Conversation
The cover image container had a fixed 250px height while the image inside kept MImage's fixed 400px width and computed height, so it spilled over the action bar. Render the image full-width with an aspect ratio from its dimensions, and show the post's caption text below it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WTpUJbH3od4yBtPRPKohFm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors image post rendering in
AppPostCardto better handle image dimensions and captions:info.wandinfo.h) to maintain proper aspect ratio, with sensible clamping (0.5–3) to prevent extreme panoramas or tall images from rendering poorly. Falls back to 4:3 when dimensions are unavailable.bodyfield differs from thefilename(per Matrix spec). Captions are rendered below the image using the existingMTextandRenderBodycomponents.MImagewrapper component with directImageContentusage, reducing indirection and making the component tree clearer..CoverImagestyling to useaspectRatioCSS property, setmaxHeight: 480px, and ensure proper overflow handling.Extracted image-related logic into a new
postImage.tsutility module with two pure functions:getPostImageAspectRatio(info)— computes and clamps aspect ratio from image dimensionshasImageCaption(content)— determines if an image event carries a captionBoth functions are covered by unit tests in
postImage.test.ts.Checklist:
postImage.test.ts)npm test)https://claude.ai/code/session_01WTpUJbH3od4yBtPRPKohFm