Mark the two doc-invoked host scripts executable - #164
Open
gjjkbssg wants to merge 1 commit into
Open
Conversation
README, AGENTS, CONTRIBUTING and docs/seam.md run scripts/build-host.sh directly, and docs/benchmarks.md runs scripts/bench-run.sh the same way, but both are committed 100644, so a fresh POSIX clone answers permission denied at the first documented step. Windows trees never see the mode bit, which is likely how it went unnoticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the exec-bit half of #163.
scripts/build-host.sh(invoked directly by README, AGENTS.md, CONTRIBUTING.md and docs/seam.md) andscripts/bench-run.sh(invoked directly by docs/benchmarks.md and docs/benchmark-method.md) were committed 100644, so the first documented step on a fresh POSIX clone fails with permission denied. Reproduced from a clean clone;bash scripts/...worked, which is why this hid in plain sight on a Windows working tree where the mode bit is invisible.Only the mode changes — no content diff. The other
.shdrivers are not invoked directly by the docs, so I left them for the issue discussion.No CHANGELOG line: per AGENTS.md nothing accumulates outside a dated release section, and 0.20.0 is already cut — happy to fold a line into the next dated section if you want it recorded.
Verified on macOS 15 arm64 after the bit flip:
scripts/build-host.shconfigures and builds clean, and all 10 ctest gates pass (tiny-model byte-identity included).