Feature/events api with selections#491
Merged
mudhoney merged 15 commits intoMay 26, 2026
Merged
Conversation
Contributor
mudhoney
commented
May 22, 2026
mudhoney
commented
- fix movie event framing bug for long movies,
- use selections for events-api requests cuts 2 min of movie making of events heavy long movies
…s per frame again
…ta to current event_selections code
…sentry to further refine our conversion algorithm
…tion of getting events from eventsapi, change our composite images maker to use just to know the events to draw , further simplifying our system
mudhoney
commented
May 26, 2026
| public const VALID_SOURCES = ['HEK', 'CCMC', 'RHESSI']; | ||
|
|
||
| /** Upstream-imposed cap on timestamps per batch request */ | ||
| public const MAX_CHUNK_SIZE = 150; |
Contributor
Author
There was a problem hiding this comment.
remove those, manage from ini only
| public const MAX_CHUNK_SIZE = 150; | ||
|
|
||
| /** Upstream-imposed cap on selections per frames_with_selections request */ | ||
| public const MAX_SELECTIONS = 200; |
Contributor
Author
There was a problem hiding this comment.
put comments about events-api limits
| 'moon' => false, | ||
| 'eventsApi' => null, | ||
| 'batchEventResponse' => [] | ||
| 'eventContext' => null, |
Contributor
Author
There was a problem hiding this comment.
let see to make this variable empty context, see it is better to have ?
| 'eclipse' => true, | ||
| 'moon' => $this->_options['moon'], | ||
| 'eventsApi' => $this->eventsApi() | ||
| 'eventContext' => EventContext::empty() |
Contributor
Author
There was a problem hiding this comment.
remove those, when default is empty context, then you are safer, and don't need to do this ( thanx daniel)
dgarciabriseno
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.