Repository navigation
fix: restore a green main after the i18n merges - #944
Merged
Merged
Conversation
Typecheck: duplicate useTranslations import, unused CATALOGS and catalog imports, possibly-null regex match, rich-text age placeholder, stale submitSetWhitelist argument. Lint: static StrKey import instead of require. Format: run Prettier over the 20 files merged unformatted. Tests: give the shared render helper a no-op router so LocaleProvider mounts (226 failures), add the CLDR many category to fr/es/pt plurals, keep the dollar sign in the withdraw cap message, and update expectations to the translated error codes. Use the existing pendingDepositAge key for the pending-deposit age and refresh the unused-keys baseline.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks for your contribution! ❤️ It looks like this PR isn't linked to an issue yet. Please add |
dadadave80
added
the
supply-chain-reviewed
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas failed CI since #940–#942 merged (7 type errors, a lint error, 20 unformatted files, 226 failing tests). This also turns #943 red even though it only edits a doc, becausetypecheck + lintruns on every PR.useTranslationsimport inYieldAlertProvider, unusedCATALOGS/catalog imports inLocaleProvider, possibly-null regex match incatalog-parity.test, a component passed as a rich-text value inDeposit(now uses the existingpendingDepositAgekey), and a stale fifth argument tosubmitSetWhitelist.require()inadmin/utils.tsreplaced by a staticStrKeyimport.LocaleProvidercallsuseRouter(), so the shared@/test/renderhelper threw outside an App Router.vitest.setup.tsnow mocksuseRouter(files that mocknext/navigationthemselves still win). That clears 220 of the 226. The rest: fr/es/pt plurals lacked the CLDRmanycategory the new parity test requires, the withdraw cap message lost its$, and two tests still expected untranslated error text.Local run: typecheck, lint, format:check, unused-keys, hidden-content, lockfile-lint,
test:coverage(1550 pass), build and bundle:check all pass.