Repository navigation
fix(i18n): English fallback, catalog parity checks, and pt/fr/ar translations - #941
Merged
AbelOsaretin merged 6 commits intoOct 24, 2026
Conversation
Deep-merge the English catalog under the active locale in request.ts and LocaleProvider so a deleted or misspelled key renders English copy instead of a raw `Namespace.key` path. Wire onError/getMessageFallback on both the server request config and NextIntlClientProvider: warn in dev and report through errorReporting on the client.
Fill the Nav, Portfolio, Referral and Admin blocks that were left in English, and keep genuine invariants (contract names, shared cognates like Type/Actions) untouched.
Translate the English leftovers in the Arabic catalog and complete the CLDR plural categories (zero/one/two/few/many/other) on Portfolio.activityRegion and Admin.approvalRecorded.
About 68% of pt.json was still English. Translate every user-facing string across Landing, Deposit, Portfolio, Creator, Admin and the remaining namespaces, leaving only genuine invariants (contract names, brand tagline, Stellar memo label).
…talog parity Parse messages as ICU so argument names and types are compared per key (including inside plural/select branches), require every locale's plural categories to cover its CLDR set, and run the untranslated-value check for all non-en locales against an allowlist of brands, format skeletons and shared UI tokens. Also cover the per-key English fallback.
|
@KidDev88 is attempting to deploy a commit to the David Dada's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for the PR! A maintainer will take a look shortly. ✨ |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #891, Closes #892, Closes #893, Closes #894
Type of Change
Summary
The catalog parity test only compared ICU argument names with a top-level regex
and only checked for English leftovers in
es.json, whilept.jsonwas ~68%English and
fr/arstill had whole blocks untranslated. Missing or misspelledkeys also rendered raw
Namespace.keypaths to users. This PR translates theremaining
pt/fr/arstrings, deep-merges English as a per-key fallback withonError/getMessageFallbackreporting, and rewrites the parity test to parseICU properly (argument names and types, CLDR plural categories per locale,
untranslated-value checks for every non-en locale).
Motivation / Context
Closes #891, Closes #892, Closes #893, Closes #894
pt.json(355 stringsacross Landing, Deposit, Portfolio, Creator, Admin and the tail) and the
fr/arblocks (Nav, Portfolio, Referral, Watchlist, …). Genuine invariants(contract names,
you@example.com, format skeletons, shared cognates likefr
Type/Actions) stay on the test allowlist.arguments (
Admin.liveProject,TaxReports.skippedAlertno longer risk falsepositives), compare argument names and types per key, require each locale's
plural categories to cover its
Intl.PluralRulesCLDR set (fixes twoincomplete Arabic plurals), and run the untranslated-value check for
fr,es,ptandaragainst a small allowlist. Malformed or incomplete pluralsfail with a clear parse error.
en.jsonunder the active catalog inrequest.tsandLocaleProviderso a deleted key shows English copy instead ofNamespace.key,and wire
onError/getMessageFallbackon both the server request config andNextIntlClientProvider(warn in dev, report througherrorReporting).