Skip to content

fix(oracle): run input guards on tx-queue retries and report outcomes… - #969

Merged
abayomicornelius merged 1 commit into
Heliobond:mainfrom
works-days-101010:fix/txqueue-retry-validation-guards
Oct 21, 2026
Merged

abayomicornelius merged 1 commit into
Heliobond:mainfrom
works-days-101010:fix/txqueue-retry-validation-guards

Conversation

@Mainnet-ops

Copy link
Copy Markdown
Contributor

… accurately

Deferred retries re-fetched readings and called computeScores directly, bypassing the stale-reading, conservative-fallback/cache and high-severity anomaly gates of the main pipeline. Extract those guards into fetchValidatedReadings (scoreService) and use it in both paths; a blocked retry stays queued and counts toward max retries.

The terminal log also lumped drops and duplicates into 'successfully retried'. Track retried/duplicate/blocked/dropped separately.

Description

Closes #863
Closes #862
Closes #843
Closes #861

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Testing checklist

  • Tests pass locally
  • Added new tests (if applicable)
  • Code follows project conventions

Related issues

Screenshots (if applicable)

@drips-wave

drips-wave Bot commented Oct 21, 2026

Copy link
Copy Markdown

@Mainnet-ops Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Mainnet-ops
Mainnet-ops force-pushed the fix/txqueue-retry-validation-guards branch from 8011a9c to 6e21d06 Compare October 21, 2026 20:30
@abayomicornelius
abayomicornelius merged commit f2b14d1 into Heliobond:main Oct 21, 2026
4 of 5 checks passed
dadadave80 added a commit that referenced this pull request Oct 22, 2026
…try-validation-guards"

This reverts commit f2b14d1, reversing
changes made to 3bcfb2d.
dadadave80 added a commit to Heliobond/frontend that referenced this pull request Oct 22, 2026
…, #915, #921, #920) (#924)

* ci: fail PRs that hide content in tab padding or obfuscated source (#914)

Adds scripts/check-hidden-content.mjs, run as its own CI job, to catch the
mechanical signatures of the Heliobond/backend#969 payload: lines over 400
characters in source, runs of 8+ tabs or 40+ spaces before code, bidi and
zero-width characters, eval/Function/atob/fromCharCode and escape-run
obfuscation in non-test source, and new root-level scripts not on an
allowlist. Reviewed exceptions are listed explicitly and covered by tests.

Closes #914

* ci: require a maintainer label for supply-chain changes (#915)

Adds a review gate for PRs that change package.json scripts or dependencies,
lockfiles, hooks, workflows, or tool configs. The gate prints the exact
changes as plain text (package.json key diffs and the raw diff) to the job
summary and fails until a maintainer applies the supply-chain-reviewed label.

It runs on the pull_request event with no secrets, and reads its checker
from the base branch so a PR cannot change the check that runs on it.

Closes #915

* docs: add supply-chain policy, incident response and reviewer checklist (#921)

SECURITY.md gets a Supply chain section (bun-only with a frozen lockfile,
review rules for scripts, hooks, workflows and tool configs, the new CI
gates, dependency and Action rules) and an Incident response section.
The PR template gets contributor items for root files, scripts and
dependencies and a reviewer checklist. CONTRIBUTING.md gets a step-by-step
guide for reviewing fork PRs safely, linked from both.

Closes #921

* docs: add build-secret and deploy-gate items to the mainnet checklist (#920)

The Vercel build receives every project variable, so a malicious build script
on main could read server secrets. The repo cannot change Vercel settings, so
these items are checklist entries a maintainer verifies in the dashboard:
only NEXT_PUBLIC_* in the build step, production deploys gated on CI, and
secret rotation after a reverted merge.

Refs #920

* ci(supply-chain): re-require the label after a push, watch CODEOWNERS/dependabot/actions, scan e2e and workflows, fix check names in docs

---------

Co-authored-by: dev-susa <279090861+dev-susa@users.noreply.github.com>
Co-authored-by: David Dada <daveproxy80@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment