fix(novel2movie): only resume retrieval when score chunk files exist#72
Open
santhreal wants to merge 2 commits into
Open
fix(novel2movie): only resume retrieval when score chunk files exist#72santhreal wants to merge 2 commits into
santhreal wants to merge 2 commits into
Conversation
Stray notes.txt in event_* made resume IndexError; skipping names alone still treated the dir as a hit. Require at least one score file.
Keep cache I/O in utils.novel2movie_cache and skip unparsable scores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resume treated any non-empty
event_*directory as a retrieval cache hit, then parsed-score_out of every filename. A straynotes.txtraisedIndexError. Skipping unmatched names alone still left a stray-only directory as an empty hit and skipped retrieval.iter_score_chunk_filesnow selects only*-score_*.txtentries with a parseable score, and resume runs only when at least one such file exists.Repro: a cache dir containing only
notes.txtmust not IndexError and must not count as a hit.