fix(novel2movie): avoid ZeroDivisionError on empty novel text#71
Open
santhreal wants to merge 2 commits into
Open
fix(novel2movie): avoid ZeroDivisionError on empty novel text#71santhreal wants to merge 2 commits into
santhreal wants to merge 2 commits into
Conversation
Compression summary divided by len(novel_text) with no empty guard. Print n/a via a small helper when the novel is empty.
Keep only compression_ratio_label assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The novel2movie compression summary divided by
len(novel_text)with no empty guard. An empty novel (or resume with an empty compressed artifact) raisedZeroDivisionErrorbefore later steps.compression_ratio_labelnow printsn/awhen the novel text is empty.Repro:
compression_ratio_label("", "")must not divide by zero; it returns the n/a label.