chore: land closed GUI dependency floors and workspace margin fixes - #278
Conversation
Recover the dependency intent from closed PRs #248 and #247. Main still resolved @tanstack/react-virtual 3.14.5 and @types/node 26.5.0; those pull requests raised the ranges above that. Install the current patch releases (3.14.13 and 26.6.2) with a Bun 1.4.2 lockfile. Security: both are patch bumps inside the existing major. react-virtual stays on the 3.14 API used by the logs and debug virtualizers. @types/node is dev-only and does not change the runtime. The lockfile drops nested @types/node 24 copies that now dedupe onto 26.6.2. Co-authored-by: OnlineChef <chefadmin@chefgroep.online>
Recover the margin shorthand from closed PR #172 in the three workspace stylesheets, plus the prefer-const binding in the stale websocket pump test. The other prefer-const hunks in that pull request are behavior equivalent and stay unstaged: formatting them reflows entire modules. Security: stylesheet shorthand only. The websocket test binding is never reassigned, so the stale-pump assertion is unchanged. Co-authored-by: OnlineChef <chefadmin@chefgroep.online>
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2daad1fb-d14f-401e-9161-097da5a4dba6) |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: GroepOnline/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates two GUI dependency ranges, reformats declarations in three workspace stylesheets without changing their described behavior, and changes a test variable from ChangesGUI dependency updates
Workspace CSS formatting
WebSocket endpoint test cleanup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency updates match the committed lockfile, and the CSS and test edits preserve behavior. No material merge risk is identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Summary
Recover two closed-without-merge intents that are not on
main, checked by diff rather than by the close comments.#248raised@tanstack/react-virtualfrom^3.14.5to^3.14.11. The lock onmainwas still3.14.5. This installs3.14.13(current 3.14 patch, above that floor) and@tanstack/virtual-core3.17.11. The 3.14.6–3.14.13 notes are patch fixes;useVirtualizerin Logs and Debug is unchanged.#247raised@types/nodefrom^26.4.1to^26.5.1. The lock onmainwas26.5.0, which does not satisfy^26.5.1. This installs26.6.2. Dev-only types. Nested@types/node24 copies dedupe onto that version.#172margin shorthand (0 0 8px 0to0 0 8px, and the storage 12px/16px equivalents) in the three workspace stylesheets, plusconstfor the stale websocket pump flag that is never reassigned. The other#172prefer-const hunks are behavior-equivalent and are not included: the pre-commit formatter would reflow entire modules (cleanup.ts,auth-context.ts,release-notes.ts, and several tests) for a binding-kind change.Security
@types/nodedoes not ship runtime code.react-virtualstays on the existing 3.14 API.Verification
cd gui && bun install --frozen-lockfilebun run typecheckbun test tests/ws-endpoint.test.tscd gui && bun run test && bun run lint && bun run buildbun run privacy:scanLinear
#247,#248, and the applicable hunks of#172.Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit