chore(sight): remove dead internal/eval package#26
Merged
Conversation
Confirmed orphaned — not imported anywhere outside its own test file, no cmd/ exists to wire it into, and its BuiltinSuites() referenced package paths (internal/graph, internal/audit, internal/tool) unrelated to what it claimed to test. Its RunCommand()/Now() were permanent no-op stubs that would silently "pass" any suite expecting real output. The repo's actual eval need is already served by the working top-level eval.go (package sight, RunEval/EvalCase/EvalSuite), which this doesn't touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead internal/eval package (stub implementations that always reported success/zero-duration, so broken auto-fixes could silently pass evaluation). Audit finding.
Verification