chore(inspect): remove undocumented static-analysis files duplicating sight#28
Merged
Merged
Conversation
…'s scope
dependency_check.go, symbol_search.go, api_security.go, sbom.go, and
archive.go all performed source/manifest-level static analysis — exactly
what this repo's own README says belongs to sight ("Source diff review,
code conventions, and repository static analysis belong to sight... do not
import other engines"). Confirmed unreachable from both the CLI (none
exists) and the MCP server (mcp/server.go only wires inspect_scan/
inspect_scan_dir to the website-crawling Scanner) — dead code, not just
undocumented. dependency_check.go additionally hardcoded ~33 CVEs with no
live-feed mechanism, which would have gone stale silently.
Also removes ConvertArchiveToEntries from findings_store.go — the only
caller of the now-deleted Archive type, and itself only ever called from
its own test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes undocumented static-analysis files that duplicated sight scope.
Verification