Skip to content

Tablet: Highlight the open conversation - #461

Merged
thestinger merged 1 commit into
GrapheneOS:mainfrom
talanov:fix/tablet/open-conversation-highlight
Nov 3, 2026
Merged

thestinger merged 1 commit into
GrapheneOS:mainfrom
talanov:fix/tablet/open-conversation-highlight

Conversation

@talanov

@talanov talanov commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

fixes #379

tablet-select.mov

@talanov
talanov marked this pull request as draft October 28, 2026 15:49
@talanov
talanov marked this pull request as ready for review October 28, 2026 16:00
@talanov
talanov force-pushed the fix/tablet/open-conversation-highlight branch from 5709977 to 72afcf6 Compare October 28, 2026 16:01
@RankoR
RankoR self-requested a review October 28, 2026 16:27

@RankoR RankoR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs QA

@talanov
talanov force-pushed the fix/tablet/open-conversation-highlight branch from 72afcf6 to e20c848 Compare October 28, 2026 21:10
@AntiCot

AntiCot commented Nov 2, 2026

Copy link
Copy Markdown

Tested on an Android 16 (API 36) tablet emulator using a generated SMS history.

Checked:

  • Two-pane layout and conversation list.
  • Highlighting of the currently selected conversation.
  • Switching between conversations and updating the selection highlight.
  • Scrolling through the conversation list.
  • Selection behavior with conversations containing different numbers of messages.
  • Incoming and outgoing message history.

@talanov
talanov force-pushed the fix/tablet/open-conversation-highlight branch from e20c848 to fb5b0a7 Compare November 2, 2026 18:29
@RankoR
RankoR self-requested a review November 2, 2026 18:32
@talanov

talanov commented Nov 2, 2026

Copy link
Copy Markdown
Contributor Author

@RankoR
Same here, no change, just rebased to main.

@thestinger

Copy link
Copy Markdown
Member

Needs to be rebased.

…-pane conversation list and archived list so they stand out from the list pane (fixes GrapheneOS#379)
@talanov
talanov force-pushed the fix/tablet/open-conversation-highlight branch from fb5b0a7 to cb5f29a Compare November 3, 2026 16:48
@talanov

talanov commented Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

My bad, haven't seen it.
Done.

@thestinger
thestinger merged commit a4ccc33 into GrapheneOS:main Nov 3, 2026
7 checks passed
@talanov
talanov deleted the fix/tablet/open-conversation-highlight branch November 3, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The active conversation is not highlighted on large screens

4 participants