fix: cached session settings survived a rollback - #4872
Merged
Merged
Conversation
The cached values for settings like TimeZone were only cleared by set(..), and not by commit() or rollback(). A SET inside a transaction that was rolled back therefore left the cached value in place, and it stayed wrong until the next SET happened to clear it. Clear the cache on commit and rollback, but only when the transaction actually changed a setting. commit() runs for every statement in autocommit mode, so clearing it unconditionally would keep almost nothing in the cache.
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates SessionState to invalidate its cache during transaction commits and rollbacks when local or transaction settings are modified, preventing stale cached values. It also adds corresponding unit tests in SessionStateTest to verify this behavior. I have no feedback to provide as the implementation is correct and well-tested.
rayudu3745
requested changes
Sep 28, 2026
rayudu3745
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cached values for settings like TimeZone were only cleared by set(..), and not by commit() or rollback(). A SET inside a transaction that was rolled back therefore left the cached value in place, and it stayed wrong until the next SET happened to clear it.
Clear the cache on commit and rollback, but only when the transaction actually changed a setting. commit() runs for every statement in autocommit mode, so clearing it unconditionally would keep almost nothing in the cache.