Fix side panel open sample ordering - #1695
Open
KirtiRamchandani wants to merge 1 commit into
Open
KirtiRamchandani wants to merge 1 commit into
KirtiRamchandani wants to merge 1 commit into
Conversation
This was referenced Jun 4, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1477.
Problem
The
cookbook.sidepanel-opensample opened the tab-specific side panel before setting the tab-specificpath. On the first click, Chrome showed the default side panel page; only a second click showedsidepanel-tab.html.Root cause
chrome.sidePanel.open()must run during the user gesture, but the sample configuredchrome.sidePanel.setOptions()after opening the panel. Reversing those calls inside the click handler would lose the user gesture beforeopen()runs.Solution
Preconfigure the tab-specific side panel path before the button is enabled or appended to the page. The click handlers now only call
chrome.sidePanel.open(), so the first click opens the intended side panel page while preserving the user gesture requirement.Tests
npx eslint functional-samples/cookbook.sidepanel-open/content-script.js functional-samples/cookbook.sidepanel-open/script.js functional-samples/cookbook.sidepanel-open/service-worker.jsnpx prettier --check functional-samples/cookbook.sidepanel-open/README.md functional-samples/cookbook.sidepanel-open/content-script.js functional-samples/cookbook.sidepanel-open/script.js functional-samples/cookbook.sidepanel-open/service-worker.jsgit diff --check origin/main..HEAD