Repository navigation
Conversation
Co-authored-by: sirpy <671095+sirpy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix empty admin-wallet pool after successful Celo top-up
Retry admin-wallet balance scan and recover from an empty funded-wallet list
Nov 1, 2026
Contributor
|
not required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a successful
topAdminstx on Celo, the immediate balance scan read pre-top-up balances, sofilledAddresseswas cached as[]. Every later send then timed out on the tx lock until restart. This PR adds a bounded retry to the scan, and a rescan before sends when the list is empty.Web3Wallet.js)scanFilledAddresses(). It still requires a verified admin with a balance above the minimum.scanFilledAddressesWithRetry()retries when the result is empty or the RPC throws. It makes up to 4 attempts, with exponential backoff starting at 1s.sendTransaction(whenfromis unset) andsendNativecallensureFilledAddresses()before taking the tx lock.refreshEmptyFilledAddresses()rescans only when the list is empty.no admin wallet with funds available after balance rescan, not a lock timeout.balanceScanMaxAttempts,balanceScanRetryDelayMsandbalanceRefreshCooldownMsare read from the walletconf. They have defaults.Review notes