Repository navigation
Commit rules in the repository; CI checks every pull request's own commits - #111
Merged
Merged
Conversation
… what never goes in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.8.0 release's hygiene check (R6) found that 39 of the 79 commits merged since
servicetag-v1.7.0were authored and committed under a tool's identity with attribution trailers, and two merge subjects named tool branches. The owner ruled: accept the history, record it in the release evidence, and fix the cause going forward. This is that fix.CLAUDE.md(50 lines) and a one-lineAGENTS.md: the commit identity and subject-only rule, pull-request branch naming and merging, the gates CI cannot run, what never goes in the repository, and pointers to the versioning policy, the release runbook, the planning policy, the localization rules and the roadmap issue. Every session that clones the repository reads it.tools/check-commit-hygiene.shand ahygieneCI job on pull requests: each of the PR's own commits must be authored and committed by the repository owner (GitHub as committer only on two-parent merges), carry no attribution line and no body, and no merge subject may name a tool branch; R6's content greps (e-mail, home path, foreign device serial) run over the added lines. Proven on three ranges:v1.6.0..v1.7.0passes (253 commits),v1.7.0..the pre-release master fails with 156 violations for the right reasons, this PR's own commits pass.docs/release-proofs.mdR6 saying so.Owner follow-up on GitHub: make
hygienea required check in branch protection.