Repository navigation
#102 follow-up: the scan sheet's eyebrow reads the locale observably; CI runs lint - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the 1.8.0 release-tip proofs:
:app:lintDebugfailed with one error,TagResultSheet.kt:340NonObservableLocale— the eyebrow's capitals read the locale through a non-observable fallback inside a composable, so they would not follow a language change made while the sheet is open. Every earlier release was cut lint-clean; CI ran no lint, which is how it reached master.TagResultSheet.kt:eyebrow.uppercase(LocalLocale.current.platformLocale); two imports tidied. Lint: 0 errors, 238 warnings, 1 hint.ci.yml::app:lintDebugadded to the build line.