Skip to content

fix: use prepared Windows command runner #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dankosik merged 1 commit into from
Apr 10, 2026
Merged

fix: use prepared Windows command runner #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/install/deps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,15 +376,12 @@ async function runCommand(
args: readonly string[],
options?: InstallCommandOptions,
): Promise<InstallCommandResult> {
const preparedCommand =
process.platform === "win32"
? {
args: [...args],
command,
shell: true,
windowsHide: true,
}
: await prepareInstallCommand(command, args, options?.env ?? process.env);
const preparedCommand = await prepareInstallCommand(
command,
args,
options?.env ?? process.env,
process.platform,
);

return await new Promise<InstallCommandResult>((resolve, reject) => {
const child = spawn(preparedCommand.command, preparedCommand.args, {
Expand Down
Loading