Repository navigation
Deliver background figure runs through completion events - #4
Merged
Merged
Conversation
GoatInAHat
marked this pull request as ready for review
September 9, 2026 21:57
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skill dispatches one background coordinator for generation, isolated role calls, critique and review. It returns control to the conversation and delivers the result through the host's completion notification, without scheduled check-ins or file/status polling. Hosts without background delivery use one awaited call.
Embedded Python hosts can consume run, candidate and role events through
generate_eventsor an asyncon_eventcallback. Events correlate concurrent calls; completion follows saved artifacts and traces. Closing the stream cancels and joins unfinished work. Codex terminal-event cleanup preserves the original failure when an interrupt races with completion. Existing CLI, MCP and web result shapes stay compatible.The v0.4.0 release refreshes generated integrations with ToolFactory 0.2.1, pins the OpenClaw scaffold dependency, and fixes browser packaging paths. The Firefox source archive includes the shared web sources imported by the extension. Registry publication remains conditional on configured publisher accounts.
Validation: 44 tests and 52 subtests, full ToolFactory host validation and browser/web smoke checks, two real OpenClaw end-to-end tests, workflow lint, package-content inspection, an MCPB launch outside the checkout, and a Firefox rebuild from the complete source archive. A live managed-sign-in smoke used image, text and vision calls in three separate Codex threads and verified pushed events and saved artifacts. Independent review and a skill forward-test covered background dispatch and completion delivery. Evidence and limits are recorded in
evals/completion-events/README.md.