feat: dynamically load configuration files from repo root#7
Conversation
- Move `server-settings.json` reference to repository root - Add support for loading `server-adminlist.json` from root - Update both PowerShell and Batch scripts to conditionally append args - Update README and CHANGELOG to reflect changes
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 819f8f4818
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if exist "%SettingsFile%" ( | ||
| set "LaunchArgs=%LaunchArgs% --server-settings "%SettingsFile%"" | ||
| ) |
There was a problem hiding this comment.
On a first batch-script run where %~dp0server-settings.json does not exist but the bundled example does, this presence check runs before the file is copied in the setup block below, so LaunchArgs stays empty for the rest of the session. Any server launched immediately after the script creates server-settings.json will therefore omit --server-settings and ignore the newly created root config until the user exits and restarts the batch file.
Useful? React with 👍 / 👎.
1 participant
This submission updates the scripts to dynamically load
server-settings.jsonandserver-adminlist.jsonfrom the repository root, ensuring user configurations are preserved during updates. It updates bothFactorioServerManager.ps1andexample_batch.bat, and includes documentation updates inREADME.mdandCHANGELOG.md.PR created automatically by Jules for task 16862086955058154660 started by @GhostwheeI