feat: dynamic loading of configuration files from repository root#4
feat: dynamic loading of configuration files from repository root#4GhostwheeI wants to merge 1 commit into
Conversation
- Updated FactorioServerManager.ps1 to copy template config to repository root instead of Factorio/data/. - Updated script to dynamically load server-settings.json and server-adminlist.json if they exist. - Implemented matching functionality in example_batch.bat, including delayed expansion logic for robust argument building. - Updated README.md to reflect the new dynamic loading behavior and mention support for admin lists.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f13a748e33
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [switch]$CreateSave | ||
| ) | ||
| $settingsPath = Join-Path $InstallDir 'data\server-settings.json' | ||
| $settingsPath = Join-Path $scriptRoot 'server-settings.json' |
There was a problem hiding this comment.
When upgrading an installation that has custom settings in Factorio\data\server-settings.json (the path the previous PowerShell manager created and edited), this now ignores that file and only launches with the root server-settings.json; because the repo already contains a placeholder root config, users can silently start with placeholder credentials/visibility instead of their live server config. Please migrate or fall back to the old data file when the root config has not been customized.
Useful? React with 👍 / 👎.
1 participant
This commit updates the server management scripts to store configuration files (
server-settings.jsonandserver-adminlist.json) in the repository root rather than nestled in theFactorio/data/installation directory.Scripts now dynamically check for the existence of these files and append the corresponding arguments to the server launch command only if they are present. This prevents server crashes caused by missing configuration files and standardizes the location of user settings.
The alternative batch script was updated with matching functionality using
setlocal EnableDelayedExpansionto ensure conditional argument building logic works seamlessly. Finally, the README has been updated to document these new features.PR created automatically by Jules for task 2174727217685230561 started by @GhostwheeI