docs: clarify Docker nginx SSL config file usage#14447
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the vanilla Docker installation documentation by fixing a typo and adding new sections for troubleshooting HTTPS configurations and configuring custom SSL certificates. The review feedback highlights a security concern regarding downloading private SSL keys over unencrypted HTTP with certificate checks disabled, suggesting copying local files instead. Additionally, it points out that legacy docker-compose does not support the cp command and recommends using docker compose cp.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| wget --no-check-certificate 'http://<url_to_your_chain.crt>' \ | ||
| -O chain.crt | ||
| wget --no-check-certificate 'http://<url_to_your_key.key>' \ | ||
| -O my_geonode.key |
There was a problem hiding this comment.
Downloading a private SSL key over unencrypted HTTP (http://) is a security risk because the key can be intercepted in transit. Additionally, using wget --no-check-certificate disables SSL verification, which is an insecure practice to document. Since users typically already have their custom certificates locally on the host machine, it is safer and more realistic to instruct them to copy their local files instead of downloading them via wget.
| wget --no-check-certificate 'http://<url_to_your_chain.crt>' \ | |
| -O chain.crt | |
| wget --no-check-certificate 'http://<url_to_your_key.key>' \ | |
| -O my_geonode.key | |
| # Copy your custom certificates to the current directory | |
| cp /path/to/your/chain.crt ./chain.crt | |
| cp /path/to/your/my_geonode.key ./my_geonode.key |
| docker-compose cp chain.crt nginx:/geonode-certificates/my_geonode | ||
| docker-compose cp my_geonode.key nginx:/geonode-certificates/my_geonode |
There was a problem hiding this comment.
The legacy docker-compose tool (with a hyphen) does not support the cp command, which will result in an error like ERROR: No such command: cp. To copy files to the container using Compose, you should use docker compose cp (without a hyphen, Docker Compose V2) which supports copying to/from service containers.
| docker-compose cp chain.crt nginx:/geonode-certificates/my_geonode | |
| docker-compose cp my_geonode.key nginx:/geonode-certificates/my_geonode | |
| docker compose cp chain.crt nginx:/geonode-certificates/my_geonode | |
| docker compose cp my_geonode.key nginx:/geonode-certificates/my_geonode |
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.