Skip to content

docs: clarify Docker nginx SSL config file usage#14447

Open
brynsofz wants to merge 2 commits into
GeoNode:masterfrom
brynsofz:docs/docker-nginx-ssl-config
Open

docs: clarify Docker nginx SSL config file usage#14447
brynsofz wants to merge 2 commits into
GeoNode:masterfrom
brynsofz:docs/docker-nginx-ssl-config

Conversation

@brynsofz

Copy link
Copy Markdown
Contributor

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jul 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vanilla Docker installation documentation by fixing a typo and adding new sections for troubleshooting HTTPS configurations and configuring custom SSL certificates. The review feedback highlights a security concern regarding downloading private SSL keys over unencrypted HTTP with certificate checks disabled, suggesting copying local files instead. Additionally, it points out that legacy docker-compose does not support the cp command and recommends using docker compose cp.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +184 to +187
wget --no-check-certificate 'http://<url_to_your_chain.crt>' \
-O chain.crt
wget --no-check-certificate 'http://<url_to_your_key.key>' \
-O my_geonode.key

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Downloading a private SSL key over unencrypted HTTP (http://) is a security risk because the key can be intercepted in transit. Additionally, using wget --no-check-certificate disables SSL verification, which is an insecure practice to document. Since users typically already have their custom certificates locally on the host machine, it is safer and more realistic to instruct them to copy their local files instead of downloading them via wget.

Suggested change
wget --no-check-certificate 'http://<url_to_your_chain.crt>' \
-O chain.crt
wget --no-check-certificate 'http://<url_to_your_key.key>' \
-O my_geonode.key
# Copy your custom certificates to the current directory
cp /path/to/your/chain.crt ./chain.crt
cp /path/to/your/my_geonode.key ./my_geonode.key

Comment on lines +189 to +190
docker-compose cp chain.crt nginx:/geonode-certificates/my_geonode
docker-compose cp my_geonode.key nginx:/geonode-certificates/my_geonode

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The legacy docker-compose tool (with a hyphen) does not support the cp command, which will result in an error like ERROR: No such command: cp. To copy files to the container using Compose, you should use docker compose cp (without a hyphen, Docker Compose V2) which supports copying to/from service containers.

Suggested change
docker-compose cp chain.crt nginx:/geonode-certificates/my_geonode
docker-compose cp my_geonode.key nginx:/geonode-certificates/my_geonode
docker compose cp chain.crt nginx:/geonode-certificates/my_geonode
docker compose cp my_geonode.key nginx:/geonode-certificates/my_geonode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant