Skip to content

Fix Docker warnings#14440

Merged
giohappy merged 1 commit into
masterfrom
fix-docker-warnings
Jul 14, 2026
Merged

Fix Docker warnings#14440
giohappy merged 1 commit into
masterfrom
fix-docker-warnings

Conversation

@giohappy

Copy link
Copy Markdown
Contributor

No description provided.

@giohappy
giohappy requested a review from mattiagiupponi July 14, 2026 16:07
@cla-bot cla-bot Bot added the cla-signed CLA Bot: community license agreement signed label Jul 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the env_file path interpolation in docker-compose.yml to dynamically resolve environment files using the ENVIRONMENT variable. However, Docker Compose does not support the :+ (alternate value) operator, which will trigger warnings and lead to incorrect file resolution (e.g., .envdev instead of .env_dev). It is recommended to use a dedicated ENV_FILE variable with a fallback default, such as ${ENV_FILE:-.env}, to ensure compatibility and cleaner configuration.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docker-compose.yml
Comment thread docker-compose.yml
container_name: nginx4${COMPOSE_PROJECT_NAME}
env_file:
- .env${ENVIRONMENT:+_${ENVIRONMENT}}
- .env${ENVIRONMENT:+_}${ENVIRONMENT:-}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

As noted in the comment on line 9, the :+ operator is not supported by Docker Compose interpolation. Please consider using the ENV_FILE pattern here as well to avoid warnings and ensure correct file resolution.

      - ${ENV_FILE:-.env}

Comment thread docker-compose.yml
container_name: letsencrypt4${COMPOSE_PROJECT_NAME}
env_file:
- .env${ENVIRONMENT:+_${ENVIRONMENT}}
- .env${ENVIRONMENT:+_}${ENVIRONMENT:-}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

As noted in the comment on line 9, the :+ operator is not supported by Docker Compose interpolation. Please consider using the ENV_FILE pattern here as well to avoid warnings and ensure correct file resolution.

      - ${ENV_FILE:-.env}

Comment thread docker-compose.yml
Comment thread docker-compose.yml
@giohappy
giohappy merged commit 74ca7f3 into master Jul 14, 2026
15 checks passed
@giohappy
giohappy deleted the fix-docker-warnings branch July 14, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants