Fix Dependency Review check: remove conflicting deny-licenses#9
Merged
Conversation
…low-licenses)
actions/dependency-review-action rejects specifying both allow-licenses and
deny-licenses ('You cannot specify both...'), so the check errored on every PR.
Keeping the allow-licenses allowlist preserves the policy: anything not listed
(incl. all GPL/AGPL/LGPL/SSPL variants the denylist named) is blocked by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The required Dependency Review check has been failing on every PR (e.g. #8) with:
actions/dependency-review-action@v4treatsallow-licensesanddeny-licensesas mutually exclusive and errors out before doing any actual scanning. Because the check is part of themainruleset, this blocked all merges.Fix
Remove the
deny-licensesblock and keep theallow-licensesallowlist.This preserves the intended policy: with an allowlist, anything not explicitly listed is rejected — which already covers every license the old denylist named (GPL-2.0/3.0, AGPL-*, LGPL-2.0/3.0, SSPL-1.0). The allowlist keeps the permissive set (Apache-2.0, BSD-2/3-Clause, ISC, MIT, MPL-2.0, CC-BY-4.0, CC0-1.0, Unlicense).
vulnerability-checkandlicense-checkremain enabled.Effect
Once merged, the Dependency Review check passes on PRs with no disallowed dependency changes, unblocking #8 and future PRs.