fix: time out hanging command checks - #296
Open
mikemikimike wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fixes #270
Description
run_commandnow accepts a 30-second default timeout. Callers can provide a shorter timeout for bounded execution. When a command expires, the process tree is terminated on Windows withtaskkill /T(and the process is killed on POSIX), remaining output is collected, and a deterministic failure code plus actionable diagnostic are returned.Compatibility
Existing callers retain the same successful result shape. Commands that exceed the limit now fail instead of hanging indefinitely.
Test Coverage
python -m pytest tests/test_run.py::test_run_command_times_out_and_terminates_child -q --basetemp .pytest-tmp— 1 passedpython -m pytest tests/test_run.py tests/test_invoke.py -q --basetemp .pytest-tmp— 37 passed; 6 pre-existing Windows command-shell portability failures (ls/trueare not available on Windows)python -m flake8 gator/run.py tests/test_run.py— passedgit diff --check— passedThe documented Pipenv task command was not available in this environment. The focused timeout regression uses a real sleeping child process and verifies the returned diagnostic and exit code.
AI Assistance
AI-assisted; the process-tree cleanup and regression test were reviewed against the existing subprocess API.