Do not discard successful command output written with stderr - #289
Open
YatoVoid wants to merge 1 commit into
Open
Do not discard successful command output written with stderr#289YatoVoid wants to merge 1 commit into
YatoVoid wants to merge 1 commit into
Conversation
specified_command_get_output() and invoke_all_command_executes_checks() both required an empty stderr before treating a command as successful, so a zero-exit command that wrote a benign warning to stderr (e.g. a Python DeprecationWarning) was reported as a failure and its stdout was discarded. Both now key success off the exit code alone. Fixes GatorEducator#269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
specified_command_get_output()andinvoke_all_command_executes_checks()both require an empty stderr before treating a command as successful. A command that exits 0 but writes a benign warning to stderr has its stdout discarded and is reported as a failure.What is the new behavior if this PR is merged?
Both functions key success off the exit code alone. stdout is preserved and the check passes as long as the command exits 0, regardless of stderr content.
Other information
This PR has:
This PR is a small change that fixes #269
Developers
@YatoVoid