Repository navigation
chore(locales): move French review hashes into locales/.review.json - #57
Open
ValgulNecron wants to merge 1 commit into
Open
ValgulNecron wants to merge 1 commit into
ValgulNecron wants to merge 1 commit into
Conversation
Weblate drops unknown keys such as sourceHash when it rewrites a translation file. Ran gp-module i18n stamp on minecraft-java, terraria and valheim: messages are unchanged, the 210 hashes move unchanged to locales/.review.json (Gameplane spec 019 T078). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the French
fr.jsonfiles for minecraft-java, terraria and valheim carrysourceHashinline. When Weblate rewrites a translation file, it drops unknown keys, so its first edit would delete those hashes.After: the messages are unchanged and the 210 hashes (123, 69 and 18) move unchanged into each module's
locales/.review.json. This is the location thatgp-module i18n stampandi18n-checkread since Gameplane PR #849 (spec 019 T078).How: I ran
gp-module i18n stamp <module>(built from Gameplane master a536896) on the three modules, then checked with a script that every message, description and hash matches the original file. The CIi18n-check@masterjob already understands the review file.Generated by Claude Code