Repository navigation
fix(web): override minimatch to 11.x and bump zod to 4.6.7 - #858
Conversation
Dependabot alert #32 (GHSA-g3hv-75wg-m249, minimatch >=7.0.0 <11.0.1). @typescript-eslint/typescript-estree@8.72.1 still requires ^10.2.2, so scope an npm override to that package only. The minimatch@3.1.5 copies used by eslint and eslint-plugin-react are outside the affected range and stay unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
GHSA-mrhx-c7xc-m3w5 (zod <4.6.6). zod is a dev-only dependency of eslint-plugin-react-hooks, which accepts ^4.0.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. WalkthroughThe web package manifest adds an override that sets ChangesWeb dependency override
Estimated code review effort: 2 (Simple) | ~5 minutes Change: Other Suggested labels: Merge Risk:
|
CI Report - cbb8056run 42587072761 - attempt 1 0 failed - 10 passed - 23 skipped - 35m25s elapsed Test selection: partial - per-suite table Coverage
Changed
Slowest jobs
e2e buckets run
|
Summary
Fixes two dev-only npm advisories in
web/package-lock.json.minimatch: Dependabot alert #32 (GHSA-g3hv-75wg-m249,
>=7.0.0 <11.0.1)@typescript-eslint/typescript-estree@8.72.1pulls in through^10.2.2. Its latest and canary versions still require^10.2.2, so Dependabot can't update it."@typescript-eslint/typescript-estree": { "minimatch": "^11.0.1" }, which resolves to 11.0.5. It follows the same pattern as the dompurify override from fix(web): pin monaco-editor's dompurify to 3.4.17 #794.minimatch@3.1.5copies under eslint,@eslint/*and eslint-plugin-react fall outside the affected range and stay as they are.minimatch(filePath, pattern, { dot: true }), and only forprojectService.allowDefaultProject. That export and signature are unchanged in 11.x. Our ESLint config usesproject: "./tsconfig.json", so that code path never runs, which means the alert can't be exploited here.20 || >=22. CI runs Node 24.zod: GHSA-mrhx-c7xc-m3w5 (
<4.6.6)^4.0.0.Verification
@isaacs/nonrecursive-glob-matchdependency and zod.npm audit --package-lock-onlyreports 0 vulnerabilities.npm ls minimatchshows the override applies only under typescript-estree.npx tsc --noEmitpasses. Lint and tests are left to CI.🤖 Generated with Claude Code
Summary by CodeRabbit