Skip to content

fix(web): override minimatch to 11.x and bump zod to 4.6.7 - #858

Merged
ValgulNecron merged 2 commits into
masterfrom
fix/minimatch-override
Nov 9, 2026
Merged

ValgulNecron merged 2 commits into
masterfrom
fix/minimatch-override

Conversation

@ValgulNecron

@ValgulNecron ValgulNecron commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes two dev-only npm advisories in web/package-lock.json.

minimatch: Dependabot alert #32 (GHSA-g3hv-75wg-m249, >=7.0.0 <11.0.1)

  • The only affected copy is minimatch 10.2.6, which @typescript-eslint/typescript-estree@8.72.1 pulls in through ^10.2.2. Its latest and canary versions still require ^10.2.2, so Dependabot can't update it.
  • This PR adds a scoped override, "@typescript-eslint/typescript-estree": { "minimatch": "^11.0.1" }, which resolves to 11.0.5. It follows the same pattern as the dompurify override from fix(web): pin monaco-editor's dompurify to 3.4.17 #794.
  • The minimatch@3.1.5 copies under eslint, @eslint/* and eslint-plugin-react fall outside the affected range and stay as they are.
  • typescript-estree calls only minimatch(filePath, pattern, { dot: true }), and only for projectService.allowDefaultProject. That export and signature are unchanged in 11.x. Our ESLint config uses project: "./tsconfig.json", so that code path never runs, which means the alert can't be exploited here.
  • minimatch 11 needs Node 20 || >=22. CI runs Node 24.

zod: GHSA-mrhx-c7xc-m3w5 (<4.6.6)

  • Lockfile-only bump from 4.4.3 to 4.6.7. zod is a dev-only dependency of eslint-plugin-react-hooks, which accepts ^4.0.0.

Verification

  • Lockfile regenerated with npm 11. The diff touches only minimatch, the new @isaacs/nonrecursive-glob-match dependency and zod.
  • npm audit --package-lock-only reports 0 vulnerabilities.
  • npm ls minimatch shows the override applies only under typescript-estree.
  • npx tsc --noEmit passes. Lint and tests are left to CI.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated internal package configuration as part of routine maintenance. This update does not add or remove user-facing functionality, and it does not change the app’s visible behavior. Existing screens and workflows remain unchanged, so no action is needed to continue using the app as before.

Dependabot alert #32 (GHSA-g3hv-75wg-m249, minimatch >=7.0.0 <11.0.1).
@typescript-eslint/typescript-estree@8.72.1 still requires ^10.2.2, so
scope an npm override to that package only. The minimatch@3.1.5 copies
used by eslint and eslint-plugin-react are outside the affected range
and stay unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
GHSA-mrhx-c7xc-m3w5 (zod <4.6.6). zod is a dev-only dependency of
eslint-plugin-react-hooks, which accepts ^4.0.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Claude <noreply@anthropic.com>
@ValgulNecron ValgulNecron added type: security Security hardening or vulnerability fix area: web React dashboard labels Nov 9, 2026 — with Claude
@ValgulNecron ValgulNecron self-assigned this Nov 9, 2026
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The web package manifest adds an override that sets minimatch to ^11.0.1 for @typescript-eslint/typescript-estree.

Changes

Web dependency override

Layer / File(s) Summary
Pin minimatch dependency
web/package.json
The manifest overrides the minimatch dependency used by @typescript-eslint/typescript-estree to ^11.0.1.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested labels: type: fix, type: security, area: web

Merge Risk: Minimal · up to cbb80

No merge-blocking issue is identified; run the normal lint and test checks before merging.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two changes in the PR: the minimatch override to 11.x and the zod bump to 4.6.7. The raw summary only describes the package.json minimatch override and does not mention zod. The PR…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two changes in the PR: the minimatch override to 11.x and the zod bump to 4.6.7. The raw summary only describes the package.json minimatch override and does not mention zod. The PR objectives confirm the zod update from 4.4.3 to 4.6.7 in package-lock.json. The title is accurate and specific, but the zod part cannot be checked against the visible diff because package-lock.json is excluded from review. The title uses the fix(web) conventional-commit format and stays under 72 characters.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4f5f5aa and cbb8056.

Files ignored due to path filters: 1

  • web/package-lock.json is excluded by !**/package-lock.json
Files selected for processing: 1

  • web/package.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 14

  • GitHub Check: build (full, amd64)
  • GitHub Check: build (web, amd64)
  • GitHub Check: build (web, arm64)
  • GitHub Check: build (dashboard-api, amd64)
  • GitHub Check: build (dashboard-api, arm64)
  • GitHub Check: build (full, arm64)
  • GitHub Check: standalone Compose smoke
  • GitHub Check: web
  • GitHub Check: web e2e (mock)
  • GitHub Check: build e2e images
  • GitHub Check: build e2e images (arm64)
  • GitHub Check: CodeRabbit
  • GitHub Check: design vs browser visual diff
  • GitHub Check: en-XA screenshots (spec 019)
Additional context used

Code guidelines: 2

AGENTS.md — auto-discovered
docs/contributing.md — auto-discovered
Path-based instructions: 2

Source excerpt: **Coverage minimums:** netguard 91, gameaction 91, gameproto 90, telemetryschema 90, i18n 90, gp-module 80, operator 72, api 80, agent 90, svcutil 90; audit-syslog-bridge, telemetry-receiver, sentinel, capture-sidecar, mcp-s...

CodeRabbit inference engine (AGENTS.md)

Files:

  • web/package.json
Applicability reference: AGENTS.md: # Gameplane — AI assistant guide Architecture, commands, and binding rules for AI agents.

CodeRabbit inference engine (docs/contributing.md)

Files:

  • web/package.json

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown

CI Report - cbb8056

run 42587072761 - attempt 1

0 failed - 10 passed - 23 skipped - 35m25s elapsed

Test selection: partial - per-suite table

Coverage

Module Measured Gate Margin
web L95.95 S94.45 B89.33 F91.95 L92 S92 B82 F76 +2.45

Changed

Area Files +/-
web/ 2 +19/-8

Slowest jobs

Job Duration
e2e web live / amd64 (kind) 15m47s
build e2e images 15m44s
build e2e images (arm64) 11m37s
e2e web live / arm64 (kind) 11m19s
web 5m54s

e2e buckets run

multicluster, upgrade

@ValgulNecron
ValgulNecron merged commit 0e84a6b into master Nov 9, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: web React dashboard type: security Security hardening or vulnerability fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants