Repository navigation
Record history honors deletion (staging port of #137) - #138
Conversation
#137) Deleting a record removes its stored versions, and account purges remove the account's versions with its records. Migration 016 indexes record_version(did).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: GainForest/hyperindex/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63d10a1437
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Same as #137's follow-up: Records.Delete / DeleteByDID / PurgeActorData delete record_version rows in the same transaction (covering Tap and legacy Jetstream deletes), and migration 016 removes history the 015-era build kept for deleted records and purged accounts before adding the did index.
|
Addressed in the latest commits: history is now deleted inside |
This branch was successfully deployed
1 participant
Staging port of #137 so production honors deletion in record history: deleting a record removes its versions, and deleted, deactivated or taken-down accounts lose theirs in the same purge transaction. Adds migration 016 (
record_version(did)index). Same code as #137, adapted to staging'srecords.Deletepath.Verified on this branch: lint,
go test -race ./...on SQLite and PostgreSQL 17, and integration tests.