Skip to content

Attempt at optimisations - #2

Merged
GDCloudstrike merged 3 commits into
masterfrom
optimisations-(hopefully)
Aug 9, 2026
Merged

Attempt at optimisations#2
GDCloudstrike merged 3 commits into
masterfrom
optimisations-(hopefully)

Conversation

@GDCloudstrike

Copy link
Copy Markdown
Member

Summary

This PR attempts to optimize some of the variantnames handling.
Please review thorougly, I have never done optimisations before and my knowledge about it is limited.

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

@GDCloudstrike GDCloudstrike added the Performance Changes with the goal of improving performance. label Aug 9, 2026

@boubou19 boubou19 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is good as is as it's too early to say if we do micro optimizations yet or not, but feel free to adress all the nits i made before merging the PR if you think it's worth.

Comment thread src/main/java/com/LazyFlesh/variablehorizons/variants/VariantNames.java Outdated
Comment thread src/main/java/com/LazyFlesh/variablehorizons/variants/VariantNames.java Outdated
Comment thread src/main/java/com/LazyFlesh/variablehorizons/variants/VariantNames.java Outdated
@GDCloudstrike
GDCloudstrike enabled auto-merge (squash) August 9, 2026 22:23
@GDCloudstrike
GDCloudstrike merged commit bee3f00 into master Aug 9, 2026
1 check passed
@GDCloudstrike
GDCloudstrike deleted the optimisations-(hopefully) branch August 9, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Performance Changes with the goal of improving performance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants