Avoid Gradle configuration cache serializer limitations by adjusting lambda captures - #110
Merged
Merged
Conversation
eigenraven
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues with RFG jar tasks when the configuration cache is enabled.
The RFG object graph has a cycle:
MinecraftExtension.dependenciesForAccessTransformerScan(=compileClasspath) → resolved artifacts →DependencyDeobfuscationTransform$Parameters.fieldsCsv→ provider chain fromSharedMCPTasks→ lambdas that capturemcExt→ back toMinecraftExtension.Gradle's configuration cache can normally serialize cycles, but appears to fail when the re-entry point is a Java-serialized lambda.
The fix is to hoist more properties into locals so the provider lambdas capture the
Providerobjects instead ofmcExt/this. This is the same trick already used elsewhere in the code.mcpExtractRoot— capturemcVersion/mcpMappingChannel/mcpMappingVersionproviders, notmcExtforgeSrgLocation— captureuseForgeEmbeddedMappingsand the two extract-root providers as localsgenerateForgeSrgMappingsblock — hoistuserdevFile(...)/mcpFile(...)calls out of theflatMaplambdas (calling them inside capturesthis→mcExt)Checklist