Skip to content

Corrected spelling mistakes - #7917

Open
Spaghetti-OberNub wants to merge 3 commits into
masterfrom
corrected-spelling-mistakes
Open

Corrected spelling mistakes #7917
Spaghetti-OberNub wants to merge 3 commits into
masterfrom
corrected-spelling-mistakes

Conversation

@Spaghetti-OberNub

@Spaghetti-OberNub Spaghetti-OberNub commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Phosphorous is an adjective, the correct form is phosphorus. I hope this doesn't break anything.

Partly closes Issue 26429

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy

@Spaghetti-OberNub Spaghetti-OberNub added Enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. Refactor For PRs rewriting a part of the code to have a nicer code overall. labels Sep 2, 2026

@UltraProdigy UltraProdigy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best not to rename internal material identifiers solely for a spelling correction. The GT material rename changes material and OreDict keys, while the GT++ rename changes the generated item and fluid registry names. Without explicit remapping, existing P-UF6 cells becoming missing items.

The Pentoxide rename is less dangerous because its numeric material ID remains unchanged, but it would still require legacy aliases for OreDict and other name based lookups. I’d just stick with the lang correction, especially since a full material rework is planned soon anyway.

I already opened a PR correcting the Pentoxide display name, but it looks like PUF6 still needs the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. Refactor For PRs rewriting a part of the code to have a nicer code overall.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phosphorous Pentoxide Dust is labelled P4O1 in the tooltip

3 participants