Corrected spelling mistakes - #7917
Open
Spaghetti-OberNub wants to merge 3 commits into
Open
Conversation
UltraProdigy
requested changes
Sep 2, 2026
Member
There was a problem hiding this comment.
Best not to rename internal material identifiers solely for a spelling correction. The GT material rename changes material and OreDict keys, while the GT++ rename changes the generated item and fluid registry names. Without explicit remapping, existing P-UF6 cells becoming missing items.
The Pentoxide rename is less dangerous because its numeric material ID remains unchanged, but it would still require legacy aliases for OreDict and other name based lookups. I’d just stick with the lang correction, especially since a full material rework is planned soon anyway.
I already opened a PR correcting the Pentoxide display name, but it looks like PUF6 still needs the same fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phosphorous is an adjective, the correct form is phosphorus. I hope this doesn't break anything.
Partly closes Issue 26429
Checklist